{"affected":[{"database_specific":{"last_known_affected_version_range":"<= 1.0.0-dev.28","source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/10/GHSA-fmj7-7gfw-64pg/GHSA-fmj7-7gfw-64pg.json"},"package":{"ecosystem":"Pub","name":"agent_dart","purl":"pkg:pub/agent_dart"},"ranges":[{"events":[{"introduced":"0"},{"fixed":"1.0.0-dev.29"}],"type":"ECOSYSTEM"}],"versions":["0.0.1","0.0.2","0.0.4","0.0.5","0.0.6","0.1.0","0.1.1","0.1.10","0.1.11","0.1.12","0.1.13","0.1.14","0.1.14+1","0.1.15","0.1.15+1","0.1.15+2","0.1.16","0.1.16+1","0.1.16+2","0.1.17","0.1.17+1","0.1.18","0.1.19","0.1.19+1","0.1.19+2","0.1.19+3","0.1.19+4","0.1.2","0.1.21","0.1.22","0.1.22+1","0.1.23","0.1.23+1","0.1.24","0.1.24+1","0.1.3","0.1.4","0.1.5","0.1.6","0.1.7","0.1.8","0.1.9","1.0.0-dev.1","1.0.0-dev.10","1.0.0-dev.11","1.0.0-dev.13","1.0.0-dev.14","1.0.0-dev.15","1.0.0-dev.16","1.0.0-dev.17","1.0.0-dev.18","1.0.0-dev.19","1.0.0-dev.2","1.0.0-dev.20","1.0.0-dev.21","1.0.0-dev.22","1.0.0-dev.23","1.0.0-dev.24","1.0.0-dev.25","1.0.0-dev.26","1.0.0-dev.27","1.0.0-dev.28","1.0.0-dev.3","1.0.0-dev.4","1.0.0-dev.5","1.0.0-dev.6","1.0.0-dev.7","1.0.0-dev.8","1.0.0-dev.9"]}],"aliases":["CVE-2024-48915"],"database_specific":{"cwe_ids":["CWE-295","CWE-347"],"github_reviewed":true,"github_reviewed_at":"2024-10-15T17:33:50Z","nvd_published_at":"2024-10-15T17:15:11Z","severity":"HIGH"},"details":"Certificate verification (in [lib/agent/certificate.dart](https://github.com/AstroxNetwork/agent_dart/blob/main/lib/agent/certificate.dart)) has been found to contain two issues:\n   - During the delegation verification (in [_checkDelegation](https://github.com/AstroxNetwork/agent_dart/blob/f50971dfae3f536c1720f0084f28afbcf5d99cb5/lib/agent/certificate.dart#L162) function) the canister_ranges aren't verified. The impact of not checking the canister_ranges is that a subnet can sign canister responses in behalf of another subnet. You have more details in the IC specification [here](https://internetcomputer.org/docs/current/references/ic-interface-spec#certification-delegation). Also for reference you can check how is this implemented in [the agent-rs](https://github.com/dfinity/agent-rs/blob/608a3f4cfdcdfc5ca1ca74a1b9d33f2137a2d324/ic-agent/src/agent/mod.rs#L903-L914).\n    - The certificate’s timestamp, i.e /time path, is not verified, meaning that the certificate effectively has no expiration time. The [IC spec](https://internetcomputer.org/docs/current/references/ic-interface-spec#http-query) doesn’t specify an expiry times, it gives some suggestions, quoting: \"A reasonable expiry time for timestamps in R.signatures and the certificate Cert is 5 minutes (analogously to the maximum allowed ingress expiry enforced by the IC mainnet). Delegations require expiry times of at least a week since the IC mainnet refreshes the delegations only after replica upgrades which typically happen once a week\". For reference you can check how is this implemented in the agent-rs ([here](https://github.com/dfinity/agent-rs/blob/608a3f4cfdcdfc5ca1ca74a1b9d33f2137a2d324/ic-agent/src/agent/mod.rs#L820) and [here](https://github.com/dfinity/agent-rs/blob/608a3f4cfdcdfc5ca1ca74a1b9d33f2137a2d324/ic-agent/src/agent/mod.rs#L876-L887)).\n\n**Additionally**, seems [replica signed queries](https://internetcomputer.org/blog/features/replica-signed-queries) aren’t implemented","id":"GHSA-fmj7-7gfw-64pg","modified":"2024-10-15T23:41:01.085916Z","published":"2024-10-15T17:33:50Z","references":[{"type":"WEB","url":"https://github.com/AstroxNetwork/agent_dart/security/advisories/GHSA-fmj7-7gfw-64pg"},{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2024-48915"},{"type":"WEB","url":"https://github.com/AstroxNetwork/agent_dart/commit/0d200686aabcd9313c7bc3e675cbdc82f6b775cf"},{"type":"PACKAGE","url":"https://github.com/AstroxNetwork/agent_dart"},{"type":"WEB","url":"https://github.com/AstroxNetwork/agent_dart/blob/f50971dfae3f536c1720f0084f28afbcf5d99cb5/lib/agent/certificate.dart#L162"},{"type":"WEB","url":"https://github.com/AstroxNetwork/agent_dart/blob/main/lib/agent/certificate.dart"}],"schema_version":"1.9.0","severity":[{"score":"CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:N","type":"CVSS_V3"},{"score":"CVSS:4.0/AV:N/AC:H/AT:N/PR:N/UI:P/VC:H/VI:H/VA:N/SC:N/SI:N/SA:N","type":"CVSS_V4"}],"summary":"Agent Dart is missing certificate verification checks"}